Skip to content

fix: support WebGUI query editor - #16

Merged
marianfoo merged 2 commits into
masterfrom
codex/fix-base-run-001
Aug 6, 2026
Merged

marianfoo merged 2 commits into
masterfrom
codex/fix-base-run-001

Conversation

@marianfoo

Copy link
Copy Markdown
Owner

Goal

Fix BASE-RUN-001 so ZTOAD reaches a usable query editor in SAP WebGUI without creating a new ST22 dump.

What changed

  • add a narrow editor adapter that uses CL_GUI_TEXTEDIT in WebGUI and retains CL_GUI_ABAPEDIT on desktop SAP GUI
  • preserve desktop F1, completion, quick-info, insert-pattern, and drag/drop behavior
  • add two ABAP Unit tests for the frontend-selection policy
  • document the rejected SQL source-type spike, live root cause, NPL ADT-only target, and current validation/process evidence

Root cause

CL_GUI_ABAPEDIT publishes ABAP lexer data through DP_PUBLISH_URL and is not usable in the tested WebGUI runtime. Changing only its source type avoided the lexer call but left an invalid source-editor control handle and produced a second live dump.

Validation

  • npm ci: passed, 0 vulnerabilities
  • npm test: 0 configured abaplint findings
  • git diff --check: passed
  • A4H active source: no inactive divergence
  • A4H syntax: 0 errors, 4 unchanged legacy warnings
  • A4H ABAP Unit: 19 passed, 0 failed
  • A4H ATC ABAP_CLOUD_READINESS: 768 findings (463 P1, 305 P2), recorded as architectural debt
  • A4H ATC S4HANA_READINESS_2023: no rows returned, but known prerequisites remain unavailable
  • fresh WebGUI launch: editor renders and accepts SELECT SINGLE mandt FROM t000
  • post-smoke ST22: no new dump

Known gates

  • Full query dispatch is blocked by the A4H installation missing GUI status STATUS010, tracked separately as BASE-BUG-007 even though the status exists in repository XML.
  • Exact NPL/7.50 ZTOAD activation is blocked because transparent table ZTOAD is absent and SAP_BASIS 750 has no ADT transparent-table create endpoint. NPL remains ARC-1/ADT-only; no FLP or SAPGUI automation is used there.

@marianfoo
marianfoo marked this pull request as ready for review August 6, 2026 11:05
@marianfoo
marianfoo merged commit ca17984 into master Aug 6, 2026
3 checks passed
@marianfoo
marianfoo deleted the codex/fix-base-run-001 branch August 6, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant